Renaming BluetoothDeviceMac as BluetoothClassicDeviceMac

device/bluetooth/bluetooth_device.h

Index: device/bluetooth/bluetooth_device.h
diff --git a/device/bluetooth/bluetooth_device.h b/device/bluetooth/bluetooth_device.h
index 09d179777ac7a088d1654151b8ffb7ff2857bf15..9cfb739db3a3978deb3727f6b0e604dfbe2c0816 100644
--- a/device/bluetooth/bluetooth_device.h
+++ b/device/bluetooth/bluetooth_device.h
@@ -188,6 +188,14 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothDevice {
 
   virtual ~BluetoothDevice();
 
+  // Indicates whether the device supports bluetooth low energy. Note that false
+  // negatives are possible if supports_low_energy_ is not set on construction.
+  virtual bool SupportsLowEnergy() const;

[scheib, 2015/06/29 20:44:24]

Unless Arman is already on board with this, I think we should handle this wholly
in Mac code. Instead of type checking let's add a virtual method for what we
need. It's OK to static cast to the platform specific base class then
(BluetoothDeviceMac):

BluetoothDevice
  ^
  |
  BluetoothDeviceMac
  + NSDate* GetLastUpdateTime() = 0;
  ^ ^
  | |
  | BlueoothClassicDeviceMac
  | + NSDate* GetLastUpdateTime() { ... inquiryUpdate ... };
  | 
  BlueoothLowEnergyDeviceMac
  + NSDate* GetLastUpdateTime();


BluetoothAdapterMac::UpdateDevices() {
  ... static_cast<BluetoothDeviceMac>(device) ...

[krstnmnlsn, 2015/06/30 00:50:35]

Done. See https://codereview.chromium.org/1211013005/.

+
+  // Indicates whether the device supports bluetooth classic. Note that false
+  // negatives are possible if supports_classic_ is not set on construction.
+  virtual bool SupportsClassic() const;
+
   // Returns the Bluetooth class of the device, used by GetDeviceType()
   // and metrics logging,
   virtual uint32 GetBluetoothClass() const = 0;
@@ -452,6 +460,10 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothDevice {
   // the specific data. The data is stored as BinaryValue.
   scoped_ptr<base::DictionaryValue> services_data_;
 
+  // Indicates whether the device supports low energy and classic.
+  bool supports_low_energy_;

[scheib, 2015/06/29 20:44:24]

Members need values in constructor or being added here with = false;

[krstnmnlsn, 2015/06/30 00:50:35]

Acknowledged.

+  bool supports_classic_;
+
  private:
   // Returns a localized string containing the device's bluetooth address and
   // a device type for display when |name_| is empty.