Renaming BluetoothDeviceMac as BluetoothClassicDeviceMac

device/bluetooth/bluetooth_device.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef DEVICE_BLUETOOTH_BLUETOOTH_DEVICE_H_
 #define DEVICE_BLUETOOTH_BLUETOOTH_DEVICE_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 170 matching lines @@
     // authorized. The delegate should decide whether the user should confirm
     // or not, then call ConfirmPairing() on the device to confirm the pairing
     // (whether by user action or by default), RejectPairing() on the device to
     // reject or CancelPairing() on the device to cancel authorization for
     // any other reason.
     virtual void AuthorizePairing(BluetoothDevice* device) = 0;
   };
 
   virtual ~BluetoothDevice();
 
+  // Indicates whether the device supports bluetooth low energy. Note that false
+  // negatives are possible if supports_low_energy_ is not set on construction.
+  virtual bool SupportsLowEnergy() const;

[scheib, 2015/06/29 20:44:24]

Unless Arman is already on board with this, I think we should handle this wholly
in Mac code. Instead of type checking let's add a virtual method for what we
need. It's OK to static cast to the platform specific base class then
(BluetoothDeviceMac):

BluetoothDevice
  ^
  |
  BluetoothDeviceMac
  + NSDate* GetLastUpdateTime() = 0;
  ^ ^
  | |
  | BlueoothClassicDeviceMac
  | + NSDate* GetLastUpdateTime() { ... inquiryUpdate ... };
  | 
  BlueoothLowEnergyDeviceMac
  + NSDate* GetLastUpdateTime();


BluetoothAdapterMac::UpdateDevices() {
  ... static_cast<BluetoothDeviceMac>(device) ...

[krstnmnlsn, 2015/06/30 00:50:35]

Done. See https://codereview.chromium.org/1211013005/.

+
+  // Indicates whether the device supports bluetooth classic. Note that false
+  // negatives are possible if supports_classic_ is not set on construction.
+  virtual bool SupportsClassic() const;
+
   // Returns the Bluetooth class of the device, used by GetDeviceType()
   // and metrics logging,
   virtual uint32 GetBluetoothClass() const = 0;
 
   // Returns the identifier of the bluetooth device.
   virtual std::string GetIdentifier() const;
 
   // Returns the Bluetooth of address the device. This should be used as
   // a unique key to identify the device and copied where needed.
   virtual std::string GetAddress() const = 0;
@@ skipping 244 matching lines @@
   // Mapping from the platform-specific GATT service identifiers to
   // BluetoothGattService objects.
   typedef std::map<std::string, BluetoothGattService*> GattServiceMap;
   GattServiceMap gatt_services_;
 
   // Mapping from service UUID represented as a std::string of a bluetooth
   // service to
   // the specific data. The data is stored as BinaryValue.
   scoped_ptr<base::DictionaryValue> services_data_;
 
+  // Indicates whether the device supports low energy and classic.
+  bool supports_low_energy_;

[scheib, 2015/06/29 20:44:24]

Members need values in constructor or being added here with = false;

[krstnmnlsn, 2015/06/30 00:50:35]

Acknowledged.

+  bool supports_classic_;
+
  private:
   // Returns a localized string containing the device's bluetooth address and
   // a device type for display when |name_| is empty.
   base::string16 GetAddressWithLocalizedDeviceTypeName() const;
 };
 
 }  // namespace device
 
 #endif  // DEVICE_BLUETOOTH_BLUETOOTH_DEVICE_H_