Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1220713004: Oilpan: have FrameFetchContext keep a DocumentLoader member. (Closed)

Created:
5 years, 5 months ago by sof
Modified:
5 years, 5 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, Yoav Weiss, Nate Chapin, gavinp+loader_chromium.org, tyoshino+watch_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: have FrameFetchContext keep a DocumentLoader member. With DocumentLoader now being on the heap, keep a strong back reference to the loader. R=haraken BUG=393516 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198015

Patch Set 1 #

Patch Set 2 : non-oilpan compile fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M Source/core/loader/FrameFetchContext.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FrameFetchContext.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
please take a look.
5 years, 5 months ago (2015-06-29 15:02:38 UTC) #2
haraken
LGTM
5 years, 5 months ago (2015-06-29 15:22:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220713004/20001
5 years, 5 months ago (2015-06-29 20:04:33 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 20:08:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198015

Powered by Google App Engine
This is Rietveld 408576698