Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 12207124: Change Get started to Check eligibility in the promo banner in Files.app. (Closed)

Created:
7 years, 10 months ago by mtomasz
Modified:
7 years, 10 months ago
Reviewers:
satorux1, kinaba
CC:
chromium-reviews, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Change Get started to Check eligibility in the promo banner in Files.app. The previous label has been confusing for users. TBR=satorux TEST=Check with an empty profile if the button's label is correct. BUG=172477 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181914

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/file_manager/js/drive_banners.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/file_manager/js/mock_chrome.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
mtomasz
@kinaba: One more tiny patch. PTAL, thanks!
7 years, 10 months ago (2013-02-12 06:05:17 UTC) #1
kinaba
lgtm but the BUG id in the description is wrong. (is it 172477 (fixed)!?)
7 years, 10 months ago (2013-02-12 07:01:02 UTC) #2
mtomasz
On 2013/02/12 07:01:02, kinaba wrote: > lgtm but the BUG id in the description is ...
7 years, 10 months ago (2013-02-12 07:03:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/12207124/1
7 years, 10 months ago (2013-02-12 07:03:49 UTC) #4
commit-bot: I haz the power
Presubmit check for 12207124-1 failed and returned exit status 1. INFO:root:Found 4 file(s). Running presubmit ...
7 years, 10 months ago (2013-02-12 07:03:53 UTC) #5
mtomasz
7 years, 10 months ago (2013-02-12 07:06:33 UTC) #6
@satorux: PTAL at the private api file.

Powered by Google App Engine
This is Rietveld 408576698