Issue 12207123: Improve matcher descriptions that match against objects, and thus fix a bug

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12207123: Improve matcher descriptions that match against objects, and thus fix a bug (Closed)

Created:
7 years, 10 months ago by gram

Modified:
7 years, 10 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Improve matcher descriptions that match against objects, and thus fix a bug in mocking library. See https://code.google.com/p/dart/issues/detail?id=7039 Committed: https://code.google.com/p/dart/source/detail?r=18386

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -0 lines)			Patch
	M	pkg/unittest/lib/src/description.dart	View		1 chunk	+6 lines, -0 lines	0 comments	Download
	M	pkg/unittest/test/mock_test.dart	View		1 chunk	+12 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Siggi Cherem (dart-lang)

7 years, 10 months ago (2013-02-12 01:57:39 UTC) #2

lgtm

lgtm - but it's definitely strange to see this, why printing something in a
description fixes that issue?