Issue 12207120: Remove bad const from disk_cache::Backend interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12207120: Remove bad const from disk_cache::Backend interface. (Closed)

Created:
7 years, 10 months ago by gavinp

Modified:
7 years, 10 months ago

Reviewers:
rvargas (doing something else)

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, gavinp+disk_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Remove bad const from disk_cache::Backend interface. http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Use_of_const tells me not to use const where it's confusing. The instances of const removed by this CL are definitely confusing since they aren't even part of the interfaces they're written in. Worse yet, our Windows compiler gives errors if you override without matching them. This issue is upstream of https://codereview.chromium.org/12192005/ (Add simple cache backend), and must land before it so as to not break the windows build. R=rvargas@chromium.org BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182065

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -15 lines)			Patch
M	net/disk_cache/backend_impl.h	View	1 2	2 chunks	+6 lines, -6 lines	0 comments	Download
M	net/disk_cache/disk_cache.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	net/disk_cache/mem_backend_impl.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	net/http/mock_http_cache.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 5 (0 generated)

gavinp

On 2013/02/12 20:38:43, rvargas wrote: > lgtm Thanks! I'll be happy to have this out ...

7 years, 10 months ago (2013-02-12 20:39:08 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/12207120/5

7 years, 10 months ago (2013-02-12 20:39:21 UTC) #4

Message was sent while issue was closed.

Change committed as 182065