chrome/browser/extensions/extension_install_ui_default.cc - Issue 12207104: Refactor app_list_util.h into AppListService abstract base.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_install_ui_default.cc

Issue 12207104: Refactor app_list_util.h into AppListService abstract base. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix some obvious dumbs Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/webstore_private/webstore_private_api.cc ('k') | chrome/browser/prefs/browser_prefs.cc » ('j') | chrome/browser/ui/app_list/app_list_controller_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_install_ui_default.cc

diff --git a/chrome/browser/extensions/extension_install_ui_default.cc b/chrome/browser/extensions/extension_install_ui_default.cc

index 6fe870b6e8b374727938cc3788caf3179793f9e8..2643571c69192a4061f7920f99290f2eb87f55bc 100644

--- a/chrome/browser/extensions/extension_install_ui_default.cc

+++ b/chrome/browser/extensions/extension_install_ui_default.cc

@@ -15,7 +15,7 @@

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/themes/theme_service.h"

#include "chrome/browser/themes/theme_service_factory.h"

-#include "chrome/browser/ui/app_list/app_list_util.h"

+#include "chrome/browser/ui/app_list_service.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_dialogs.h"

#include "chrome/browser/ui/browser_finder.h"

@@ -108,9 +108,10 @@ void OnAppLauncherEnabledCompleted(const extensions::Extension* extension,

SkBitmap* icon,

bool use_bubble,

bool use_launcher) {

+// TODO(tapted): Remove this ifdef.

tapted 2013/02/11 04:04:20 actually, looking at the function name (OnAppLaunc

koz (OOO until 15th September) 2013/02/11 04:33:38 Sounds good to me.

tapted 2013/02/18 07:05:39 Done.

#if defined(ENABLE_APP_LIST)

if (use_launcher) {

- chrome::ShowAppList(browser->profile());

+ AppListService::Get()->ShowAppList(browser->profile());

content::NotificationService::current()->Notify(

chrome::NOTIFICATION_APP_INSTALLED_TO_APPLIST,