chrome/browser/ui/app_list/app_list_service_ash.h - Issue 12207104: Refactor app_list_util.h into AppListService abstract base.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/app_list/app_list_service_ash.h

Issue 12207104: Refactor app_list_util.h into AppListService abstract base. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase (conflicts in webstore_private_api.cc) Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/app_list/app_list_service.h ('K') | « chrome/browser/ui/app_list/app_list_service.cc ('k') | chrome/browser/ui/app_list/app_list_service_cocoa.h » ('j') | chrome/browser/ui/ash/app_list/app_list_service_ash.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_APP_LIST_APP_LIST_SERVICE_ASH_H_

	6 #define CHROME_BROWSER_UI_APP_LIST_APP_LIST_SERVICE_ASH_H_

	7

	8 class AppListService;

	9

	10 namespace chrome {

	11

	12 AppListService* GetAppListServiceAsh();
	tfarina 2013/02/21 23:04:44 Lets not do this way. It's better to have one fun Lets not do this way. It's better to have one function in a cross-platform file: AppListService* GetAppListService(); tapted 2013/02/25 07:09:21 There's not necessarily a 1:1 mapping from a platf Show quoted text On 2013/02/21 23:04:44, tfarina wrote: > Lets not do this way. > > It's better to have one function in a cross-platform file: > > AppListService* GetAppListService(); > There's not necessarily a 1:1 mapping from a platform to a service. On windows with aura/ash, we need to provide two -- one "win" and one "ash" service, so they must have different names.
	13

	14 }
	tfarina 2013/02/21 23:04:44 // namespace chrome // namespace chrome tapted 2013/02/25 07:09:21 Done. Show quoted text On 2013/02/21 23:04:44, tfarina wrote: > // namespace chrome Done.
	15

	16 #endif // CHROME_BROWSER_UI_APP_LIST_APP_LIST_SERVICE_ASH_H_

OLD	NEW