Refactor app_list_util.h into AppListService abstract base.

chrome/browser/ui/app_list/app_list_service_disabled.cc

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/app_list/app_list_service.h"
+
+#include "base/file_path.h"
+#include "base/logging.h"
+
+namespace {
+
+class AppListServiceDisabled : public AppListService {
+ public:
+  AppListServiceDisabled() {}
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(AppListServiceDisabled);
+};
+
+AppListServiceDisabled* GetDisabled() {

[benwells, 2013/02/21 04:34:36]

For consistency, I think this should be GetAppListServiceDisabled, declared in
app_list_service_disabled.h, with the Get call in app_list_service.cc guarded
with #ifs.

[tapted, 2013/02/25 07:09:21]

Done. But have a look - maybe it would be nicer in app_list_service_selector.cc
rather than app_list_service.cc? .. not sure if they gypdeffery will like that
approach though (in which case pretend I never suggested it :p).

+  CR_DEFINE_STATIC_LOCAL(AppListServiceDisabled, disabled_instance, ());
+  return &disabled_instance;
+}
+
+}  // namespace
+
+// static
+AppListService* AppListService::Get() {
+  return GetDisabled();
+}
+
+void AppListService::InitAll(Profile* initial_profile) {}