Issue 12207092: views: Dispatch key, touch, scroll and gesture events using the EventDispatch interface.

Issue 12207092: views: Dispatch key, touch, scroll and gesture events using the EventDispatch interface. (Closed)

Created:
7 years, 10 months ago by sadrul

Modified:
7 years, 10 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

views: Dispatch key, touch, scroll and gesture events using the EventDispatch interface. BUG=173235, 159632 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182609

Patch Set 3 : tot-merge-before-land #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+101 lines, -57 lines)			Patch
M	ui/views/view.h	View		4 chunks	+6 lines, -7 lines	0 comments	Download
M	ui/views/view.cc	View	1 2	4 chunks	+61 lines, -34 lines	0 comments	Download
M	ui/views/widget/root_view.h	View	1 2	4 chunks	+11 lines, -1 line	0 comments	Download
M	ui/views/widget/root_view.cc	View		10 chunks	+23 lines, -15 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

Yes sorry I have been saving the more interesting CLs for last :-) -Ben On ...

7 years, 10 months ago (2013-02-14 23:09:09 UTC) #3

Ben Goodger (Google)

lgtm https://codereview.chromium.org/12207092/diff/3001/ui/views/widget/root_view.h File ui/views/widget/root_view.h (right): https://codereview.chromium.org/12207092/diff/3001/ui/views/widget/root_view.h#newcode141 ui/views/widget/root_view.h:141: // Overridden from ui::EventDispatcherDelegate. nit: : not .

7 years, 10 months ago (2013-02-14 23:14:36 UTC) #4

sadrul

7 years, 10 months ago (2013-02-15 01:16:53 UTC) #5

https://codereview.chromium.org/12207092/diff/3001/ui/views/widget/root_view.h
File ui/views/widget/root_view.h (right):

https://codereview.chromium.org/12207092/diff/3001/ui/views/widget/root_view....
ui/views/widget/root_view.h:141: // Overridden from ui::EventDispatcherDelegate.
On 2013/02/14 23:14:36, Ben Goodger (Google) wrote:
> nit: : not .

Done.

Expand Messages | Collapse Messages