Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Unified Diff: sdk/lib/_internal/compiler/implementation/universe/partial_type_tree.dart

Issue 12207081: Add a type kind to TypedSelector. A typed selector can either be (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/universe/partial_type_tree.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/universe/partial_type_tree.dart (revision 18306)
+++ sdk/lib/_internal/compiler/implementation/universe/partial_type_tree.dart (working copy)
@@ -9,9 +9,7 @@
final Compiler compiler;
PartialTypeTreeNode root;
- // TODO(kasperl): This should be final but the VM will not allow
- // that without making the map a compile-time constant.
- Map<ClassElement, PartialTypeTreeNode> nodes =
+ final Map<ClassElement, PartialTypeTreeNode> nodes =
new Map<ClassElement, PartialTypeTreeNode>();
// TODO(kasperl): For now, we keep track of whether or not the tree
@@ -19,9 +17,7 @@
// subclass relationship.
bool containsInterfaceSubtypes = false;
- // TODO(kasperl): This should be final but the VM will not allow
- // that without making the set a compile-time constant.
- Set<ClassElement> unseenInterfaceSubtypes =
+ final Set<ClassElement> unseenInterfaceSubtypes =
new Set<ClassElement>();
PartialTypeTree(this.compiler);
@@ -145,7 +141,6 @@
* the [visit] function ever returns false, we abort the traversal.
*/
void visitHierarchy(ClassElement type, bool visit(PartialTypeTreeNode node)) {
- assert(!containsInterfaceSubtypes);
PartialTypeTreeNode current = root;
L: while (!identical(current.type, type)) {
assert(type.isSubclassOf(current.type));

Powered by Google App Engine
This is Rietveld 408576698