sdk/lib/_internal/compiler/implementation/ssa/nodes.dart - Issue 12207081: Add a type kind to TypedSelector. A typed selector can either be

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

Issue 12207081: Add a type kind to TypedSelector. A typed selector can either be (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/codegen.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/optimize.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/ssa/nodes.dart (revision 18306)

+++ sdk/lib/_internal/compiler/implementation/ssa/nodes.dart (working copy)

@@ -1152,8 +1152,7 @@

// If the original can't be null, type conversion also can't produce null.

bool canBeNull = this.guaranteedType.canBeNull();

- HType convertedType =

- new HType.fromBoundedType(type, compiler, canBeNull);

+ HType convertedType = new HType.subtype(type, compiler);

// No need to convert if we know the instruction has

// [convertedType] as a bound.

@@ -2302,7 +2301,7 @@

}

class HTypeConversion extends HCheck {

- HType type;

+ final HType type;

final int kind;

static const int NO_CHECK = 0;

@@ -2313,6 +2312,7 @@

HTypeConversion(this.type, HInstruction input, [this.kind = NO_CHECK])

: super(<HInstruction>[input]) {

+ assert(type != null);

sourceElement = input.sourceElement;

}

HTypeConversion.checkedModeCheck(HType type, HInstruction input)