Added new GetHeapStatistics API entry and deprecated old one.

Added new GetHeapStatistics API entry and deprecated old one.

Simplified the HeapStatistics class a bit, following Uncle Bob's advice that
adding accessors to DTOs only satisfies some design fundamentalists, but serves
no other purpose. :-)

Committed: http://code.google.com/p/v8/source/detail?r=13631

[Michael Starzinger, 2013-02-08 12:30:11]

LGTM with a nit and a suggestion.

https://codereview.chromium.org/12207076/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/12207076/diff/1/src/api.cc#newcode4420
src/api.cc:4420: heap_statistics->Clear();
Since there is only one use of the Clear() method besides the constructor, and
that is in a deprecated method, one could even argue to remove the Clear()
method completely. But I'll leave that up to you.

https://codereview.chromium.org/12207076/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

https://codereview.chromium.org/12207076/diff/1/test/cctest/test-api.cc#newco...
test/cctest/test-api.cc:15204: LocalContext c1;
I know it's not your change, but can we rename the LocalContext to either
"context" or "env", that's in line with the rest of the code.

[Sven Panne, 2013-02-08 12:41:36]

Landing...

https://codereview.chromium.org/12207076/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/12207076/diff/1/src/api.cc#newcode4420
src/api.cc:4420: heap_statistics->Clear();
On 2013/02/08 12:30:11, Michael Starzinger wrote:
> Since there is only one use of the Clear() method besides the constructor, and
> that is in a deprecated method, one could even argue to remove the Clear()
> method completely. But I'll leave that up to you.

Good point, leaving the duplication as it is until everything magically vanishes
is probably a good idea, it makes this CL even smaller.