Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 12207061: Add a utility method to receive an AwContents (Closed)

Created:
7 years, 10 months ago by sgurun-gerrit only
Modified:
7 years, 10 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add a utility method to receive an AwContents from a render_process_id and a render_host_id. We need to do this conversion in multiple (at least two) places so having the utility method helps. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181325

Patch Set 1 #

Patch Set 2 : minor fix #

Total comments: 2

Patch Set 3 : add a DCHECK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M android_webview/native/aw_contents.h View 1 chunk +4 lines, -0 lines 0 comments Download
M android_webview/native/aw_contents.cc View 1 2 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
sgurun-gerrit only
please take a look, thanks.
7 years, 10 months ago (2013-02-07 03:18:37 UTC) #1
Kristian Monsen
One comment, otherwise looks good to me. Thanks for adding. https://codereview.chromium.org/12207061/diff/2001/android_webview/native/aw_contents.cc File android_webview/native/aw_contents.cc (right): https://codereview.chromium.org/12207061/diff/2001/android_webview/native/aw_contents.cc#newcode121 ...
7 years, 10 months ago (2013-02-07 03:30:55 UTC) #2
sgurun-gerrit only
https://codereview.chromium.org/12207061/diff/2001/android_webview/native/aw_contents.cc File android_webview/native/aw_contents.cc (right): https://codereview.chromium.org/12207061/diff/2001/android_webview/native/aw_contents.cc#newcode121 android_webview/native/aw_contents.cc:121: const content::RenderViewHost* rvh = One of the methods that ...
7 years, 10 months ago (2013-02-07 03:37:32 UTC) #3
sgurun-gerrit only
added a dcheck. PTAL,
7 years, 10 months ago (2013-02-07 03:39:08 UTC) #4
Kristian Monsen
Thanks I think that is clearer. Now it should be obvious to anyone calling this ...
7 years, 10 months ago (2013-02-07 03:46:44 UTC) #5
mkosiba (inactive)
lgtm
7 years, 10 months ago (2013-02-07 09:44:11 UTC) #6
benm (inactive)
lgtm
7 years, 10 months ago (2013-02-07 10:23:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sgurun@chromium.org/12207061/9001
7 years, 10 months ago (2013-02-07 15:09:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sgurun@chromium.org/12207061/9001
7 years, 10 months ago (2013-02-07 17:05:53 UTC) #9
commit-bot: I haz the power
7 years, 10 months ago (2013-02-07 17:14:50 UTC) #10
Message was sent while issue was closed.
Change committed as 181325

Powered by Google App Engine
This is Rietveld 408576698