Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Unified Diff: chrome/browser/extensions/api_actions.h

Issue 12207060: Alter the ActivityLog db table schemas. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: trying the upload again Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/activity_log_unittest.cc ('k') | chrome/browser/extensions/api_actions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api_actions.h
===================================================================
--- chrome/browser/extensions/api_actions.h (revision 182082)
+++ chrome/browser/extensions/api_actions.h (working copy)
@@ -46,7 +46,8 @@
};
static const char* kTableName;
- static const char* kTableStructure;
+ static const char* kTableBasicFields;
+ static const char* kTableContentFields[];
// Create the database table for storing APIActions, or update the schema if
// it is out of date. Any existing data is preserved.
@@ -59,7 +60,8 @@
const Type type, // e.g. "CALL"
const Verb verb, // e.g. "ADDED"
const Target target, // e.g. "BOOKMARK"
- const std::string& api_call, // full method signature incl args
+ const std::string& api_call, // full method name
+ const std::string& args, // the argument list
const std::string& extra); // any extra logging info
// Record the action in the database.
@@ -75,6 +77,7 @@
const std::string& extension_id() const { return extension_id_; }
const base::Time& time() const { return time_; }
const std::string& api_call() const { return api_call_; }
+ const std::string& args() const { return args_; }
std::string TypeAsString() const;
std::string VerbAsString() const;
std::string TargetAsString() const;
@@ -95,6 +98,7 @@
Verb verb_;
Target target_;
std::string api_call_;
+ std::string args_;
std::string extra_;
DISALLOW_COPY_AND_ASSIGN(APIAction);
« no previous file with comments | « chrome/browser/extensions/activity_log_unittest.cc ('k') | chrome/browser/extensions/api_actions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698