Connect SparseHistogram with the rest of stats system

base/metrics/histogram.h

Index: base/metrics/histogram.h
diff --git a/base/metrics/histogram.h b/base/metrics/histogram.h
index 47db60864b9739cd2a9082547b5abecadd34fcd4..fe7b7948328a6d3b18555606bc6168f8221ea876 100644
--- a/base/metrics/histogram.h
+++ b/base/metrics/histogram.h
@@ -369,16 +369,6 @@ class BASE_EXPORT Histogram : public HistogramBase {
 
   typedef std::vector<Count> Counts;
 
-  enum Inconsistencies {
-    NO_INCONSISTENCIES = 0x0,
-    RANGE_CHECKSUM_ERROR = 0x1,
-    BUCKET_ORDER_ERROR = 0x2,
-    COUNT_HIGH_ERROR = 0x4,
-    COUNT_LOW_ERROR = 0x8,
-
-    NEVER_EXCEEDED_VALUE = 0x10
-  };
-
   //----------------------------------------------------------------------------
   // For a valid histogram, input should follow these restrictions:
   // minimum > 0 (if a minimum below 1 is specified, it will implicitly be
@@ -423,7 +413,7 @@ class BASE_EXPORT Histogram : public HistogramBase {
   // produce a false-alarm if a race occurred in the reading of the data during
   // a SnapShot process, but should otherwise be false at all times (unless we
   // have memory over-writes, or DRAM failures).
-  virtual Inconsistencies FindCorruption(const HistogramSamples& samples) const;
+  virtual int FindCorruption(const HistogramSamples& samples) const OVERRIDE;

[brettw, 2013/02/28 22:56:25]

This should be moved to the HistogramBase overrides section (and you can delete
the comment). Does this comment need to be moved to the base class? There's some
stuff about race conditions.

[kaiwang, 2013/03/01 00:52:12]

This function is not pure virtual in HistogramBase, and this comment is only for
Histogram corruption. This is way I keep it in this way...

 
   //----------------------------------------------------------------------------
   // Accessors for factory constuction, serialization and testing.