Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2795)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/metrics/histogram_flattener.h

Issue 12207058: Connect SparseHistogram with the rest of stats system (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix and add tests Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/metrics/histogram.cc ('K') | « base/metrics/histogram_base_unittest.cc ('k') | base/metrics/histogram_snapshot_manager.h » ('j') | base/metrics/histogram_snapshot_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/histogram_flattener.h
diff --git a/base/metrics/histogram_flattener.h b/base/metrics/histogram_flattener.h
index 137ce980a6844879fc41713d0add2f7f2cc9e090..d23b527fcf5dcb5e43dd268e5ca11bc1b58cdb6c 100644
--- a/base/metrics/histogram_flattener.h
+++ b/base/metrics/histogram_flattener.h
@@ -26,12 +26,11 @@ class BASE_EXPORT HistogramFlattener {
// Will be called each time a type of Inconsistenies is seen on a histogram,
Ilya Sherman 2013/02/21 05:36:06 nit: Please update the comment.
kaiwang 2013/02/27 04:39:42 Done.
// during inspections done internally in HistogramSnapshotManager class.
- virtual void InconsistencyDetected(Histogram::Inconsistencies problem) = 0;
+ virtual void InconsistencyDetected(HistogramInconsistency problem) = 0;
// Will be called when a type of Inconsistenies is seen for the first time
Ilya Sherman 2013/02/21 05:36:06 nit: Please update the comment.
kaiwang 2013/02/27 04:39:42 Done.
// on a histogram.
- virtual void UniqueInconsistencyDetected(
- Histogram::Inconsistencies problem) = 0;
+ virtual void UniqueInconsistencyDetected(HistogramInconsistency problem) = 0;
// Will be called when the total logged sample count of a histogram
// differs from the sum of logged sample count in all the buckets. The
« base/metrics/histogram.cc ('K') | « base/metrics/histogram_base_unittest.cc ('k') | base/metrics/histogram_snapshot_manager.h » ('j') | base/metrics/histogram_snapshot_manager.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698