Issue 12207051: Make ManagedMode's GoBackToSafety feature kinda' multi-desktop aware...!

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12207051: Make ManagedMode's GoBackToSafety feature kinda' multi-desktop aware...! (Closed)

Created:
7 years, 10 months ago by gab

Modified:
7 years, 10 months ago

Reviewers:
Bernhard Bauer, Ben Goodger (Google)

CC:
chromium-reviews, pam+watch_chromium.org, Bernhard Bauer

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make ManagedMode's GoBackToSafety feature kinda' multi-desktop aware...! It used to be native desktop aware only (i.e. if this feature was ever triggered in Ash, it would check the state of the native desktop and potentially open a new native desktop window). Now it is slightly "better" in that it now makes the check on the correct desktop for the current WebContents, the window creation is still on the native desktop however because chrome::NewEmptyWindow() is still not multi-desktop aware... this will be taken care of in a subsequent CL when I make browser_command.cc's commands multi-desktop aware. Getting rid of some more native desktop only BrowserList:: calls :). R=ben@chromium.org BUG=129187 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181744