Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 1220703002: const'ify parameters for Element.createShadowRoot (Closed)

Created:
5 years, 5 months ago by kochi
Modified:
5 years, 5 months ago
Reviewers:
hayato
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

const'ify parameters for Element.createShadowRoot This is style-only change and no functional change. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198032

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M Source/core/dom/Element.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220703002/1
5 years, 5 months ago (2015-06-29 08:36:46 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-06-29 09:35:19 UTC) #5
kochi
PTAL
5 years, 5 months ago (2015-06-29 09:42:27 UTC) #6
hayato
lgtm
5 years, 5 months ago (2015-06-30 02:28:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220703002/1
5 years, 5 months ago (2015-06-30 02:30:56 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 02:34:06 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198032

Powered by Google App Engine
This is Rietveld 408576698