Move AppRestriction to Policy code out of //chrome

components/policy/core/browser/android/policy_converter.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_POLICY_CORE_BROWSER_ANDROID_POLICY_CONVERTER_H
+#define COMPONENTS_POLICY_CORE_BROWSER_ANDROID_POLICY_CONVERTER_H
+
+#include <jni.h>
+#include <string>
+
+#include "base/android/scoped_java_ref.h"
+#include "base/macros.h"
+#include "base/memory/scoped_ptr.h"
+#include "components/policy/policy_export.h"
+
+namespace base {
+
+class Value;
+
+}  // namespace base
+
+namespace policy {
+
+class PolicyBundle;
+class PolicyProviderAndroid;
+class Schema;
+struct PolicyNamespace;
+
+namespace android {
+
+// Populates natives policies from Java values key/value pairs. With its

[Mattias Nissler (ping if slow), 2015/07/13 09:46:05]

nit: remove "values"

[dgn, 2015/07/14 12:50:26]

Done.

+// associated java classes, allows transforming Android |Bundle|s into
+// |PolicyBundle|s and updating the native policies.

[Mattias Nissler (ping if slow), 2015/07/13 09:46:05]

nit: I don't see how this class would "update the native policies"?

[dgn, 2015/07/14 12:50:26]

I forgot to remove this after moving FlushPolicies out of this class. Done.

+class POLICY_EXPORT PolicyConverter {
+ public:
+  explicit PolicyConverter(const Schema* policy_schema);
+  ~PolicyConverter();
+
+  // Returns a policy bundle containing all policies collected since the last
+  // call to this method. The caller gains ownership of the bundle.

[Mattias Nissler (ping if slow), 2015/07/13 09:46:05]

nit: Ownership comment is redundant with scoped_ptr return type.

[dgn, 2015/07/14 12:50:26]

Done.

+  scoped_ptr<PolicyBundle> GetPolicyBundle();
+
+  base::android::ScopedJavaLocalRef<jobject> GetJavaObject();
+
+  // To be called from Java:
+  void SetPolicyBoolean(JNIEnv* env,
+                        jobject obj,
+                        jstring policyKey,
+                        jboolean value);
+  void SetPolicyInteger(JNIEnv* env,
+                        jobject obj,
+                        jstring policyKey,
+                        jint value);
+  void SetPolicyString(JNIEnv* env,
+                       jobject obj,
+                       jstring policyKey,
+                       jstring value);
+  void SetPolicyStringArray(JNIEnv* env,
+                            jobject obj,
+                            jstring policyKey,
+                            jobjectArray value);
+
+  // Converts the passed in value to the type desired by the schema. If the
+  // value is not convertible, it is returned unchanged, so the policy system
+  // can report the error.
+  // Note that this method will only look at the type of the schema, not at any
+  // additional restrictions, or the schema for value's items or properties in
+  // the case of a list or dictionary value.
+  // This method takes ownership of the passed in value, and the caller takes
+  // ownership of the return value.
+  // Public for testing.
+  static scoped_ptr<base::Value> ConvertValueToSchema(
+      scoped_ptr<base::Value> value,
+      const Schema& schema);
+
+  // Register native methods
+  static bool Register(JNIEnv* env);
+
+ private:
+  const Schema* const policy_schema_;
+
+  scoped_ptr<PolicyBundle> policy_bundle_;
+
+  base::android::ScopedJavaGlobalRef<jobject> java_obj_;
+
+  void SetPolicyValue(const std::string& key, base::Value* raw_value);

[Mattias Nissler (ping if slow), 2015/07/13 09:46:05]

Should have a comment saying that it takes ownership of |raw_value|, or better,
pass it as scoped_ptr.

[dgn, 2015/07/14 12:50:26]

Done.

+
+  DISALLOW_COPY_AND_ASSIGN(PolicyConverter);
+};
+
+}  // namespace android
+}  // namespace policy
+
+#endif  // COMPONENTS_POLICY_CORE_BROWSER_ANDROID_POLICY_CONVERTER_H