components/omnibox/suggestion_answer.cc - Issue 1220653002: Fix some case-insensitive cases for StartsWith

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/suggestion_answer.cc

Issue 1220653002: Fix some case-insensitive cases for StartsWith (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mac fix Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/omnibox/suggestion_answer.cc

diff --git a/components/omnibox/suggestion_answer.cc b/components/omnibox/suggestion_answer.cc

index db6c85a5ff4c04a79bb25bf16260c9e7bd8214f9..540b73f1d47ab0a4ba1c87c2cd0eec96be005c87 100644

--- a/components/omnibox/suggestion_answer.cc

+++ b/components/omnibox/suggestion_answer.cc

@@ -107,7 +107,8 @@ bool SuggestionAnswer::ImageLine::ParseImageLine(

// but not a valid path of an URL. The GWS frontend commonly (always?)

// redirects to HTTPS so we just default to that here.

image_line->image_url_ =

- GURL(base::StartsWith(url_string, base::ASCIIToUTF16("//"), false)

+ GURL(base::StartsWith(url_string, base::ASCIIToUTF16("//"),

+ base::CompareCase::SENSITIVE)

? (base::ASCIIToUTF16(url::kHttpsScheme) +

base::ASCIIToUTF16(":") + url_string)

: url_string);