Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4982)

Unified Diff: chrome/installer/gcapi/gcapi_omaha_experiment.cc

Issue 1220653002: Fix some case-insensitive cases for StartsWith (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Mac fix Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/gcapi/gcapi_omaha_experiment.cc
diff --git a/chrome/installer/gcapi/gcapi_omaha_experiment.cc b/chrome/installer/gcapi/gcapi_omaha_experiment.cc
index 30c013763c433e5db63b8e5ed8ed1821e28d0712..fa9ff4735a526b99192ee39161c3362dce95b72f 100644
--- a/chrome/installer/gcapi/gcapi_omaha_experiment.cc
+++ b/chrome/installer/gcapi/gcapi_omaha_experiment.cc
@@ -48,10 +48,10 @@ bool SetExperimentLabel(const wchar_t* brand_code,
// Keep all labels, but the one we want to add/replace.
base::string16 new_labels;
- for (std::vector<base::string16>::const_iterator it = entries.begin();
- it != entries.end(); ++it) {
- if (!it->empty() && !base::StartsWith(*it, label + L"=", true)) {
- new_labels += *it;
+ for (const base::string16& entry : entries) {
+ if (!entry.empty() &&
+ !base::StartsWith(entry, label + L"=", base::CompareCase::SENSITIVE)) {
grt (UTC plus 2) 2015/07/01 17:55:41 wdyt of pulling "const base::string16 label_and_se
+ new_labels += entry;
new_labels += google_update::kExperimentLabelSeparator;
}
}

Powered by Google App Engine
This is Rietveld 408576698