Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: net/base/net_util.cc

Issue 1220653002: Fix some case-insensitive cases for StartsWith (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/net_util.cc
diff --git a/net/base/net_util.cc b/net/base/net_util.cc
index c59b3cd7ff4e91e1468ae5ca13a3c8110cc07882..3f36382aab2fcaeac65a0a2f2c4c4b688827f0f4 100644
--- a/net/base/net_util.cc
+++ b/net/base/net_util.cc
@@ -279,7 +279,8 @@ bool IsCanonicalizedHostCompliant(const std::string& host) {
base::string16 StripWWW(const base::string16& text) {
const base::string16 www(base::ASCIIToUTF16("www."));
- return base::StartsWith(text, www, true) ? text.substr(www.length()) : text;
+ return base::StartsWith(text, www, base::CompareCase::INSENSITIVE_ASCII)
sky 2015/07/01 03:18:28 It seems right that this code is insensitive, yet
brettw 2015/07/01 16:54:26 This was a mistake, I didn't mean to change it. I
+ ? text.substr(www.length()) : text;
}
base::string16 StripWWWFromHost(const GURL& url) {

Powered by Google App Engine
This is Rietveld 408576698