Fix some case-insensitive cases for StartsWith

net/base/net_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/net_util.h"
 
 #include <errno.h>
 #include <string.h>
 
 #include <algorithm>
@@ skipping 261 matching lines @@
     } else if (!IsHostCharAlphanumeric(c) && (c != '-') && (c != '_')) {
       return false;
     }
   }
 
   return most_recent_component_started_alphanumeric;
 }
 
 base::string16 StripWWW(const base::string16& text) {
   const base::string16 www(base::ASCIIToUTF16("www."));
-  return base::StartsWith(text, www, true) ? text.substr(www.length()) : text;
+  return base::StartsWith(text, www, base::CompareCase::INSENSITIVE_ASCII)

[sky, 2015/07/01 03:18:28]

It seems right that this code is insensitive, yet previously it was sensitive.
Is this an ok change? Meaning I'm not familiar with what callers of this expect.

[brettw, 2015/07/01 16:54:26]

This was a mistake, I didn't mean to change it. I fixed it.

If it's dealing with normal host names, they'll already be lower-cased so the
existing code doesn't jump out as necessarily wrong to me.

+      ? text.substr(www.length()) : text;
 }
 
 base::string16 StripWWWFromHost(const GURL& url) {
   DCHECK(url.is_valid());
   return StripWWW(base::ASCIIToUTF16(url.host()));
 }
 
 bool IsPortValid(int port) {
   return port >= 0 && port <= std::numeric_limits<uint16_t>::max();
 }
@@ skipping 538 matching lines @@
   };
   const std::string& host = url.host();
   for (const char* suffix : kGoogleHostSuffixes) {
     if (base::EndsWith(host, suffix, false))
       return true;
   }
   return false;
 }
 
 }  // namespace net