Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1220643002: Revert of [DevTools] Implement screen orientation override. (Closed)

Created:
5 years, 5 months ago by amineer_google
Modified:
5 years, 5 months ago
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, mlamouri+watch-blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of [DevTools] Implement screen orientation override. (patchset #3 id:40001 of https://codereview.chromium.org/1195793008/) Reason for revert: Causing crashes BUG=505293 Original issue's description: > [DevTools] Implement screen orientation override. > > BUG=427199 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197908 TBR=mlamouri@chromium.org,pfeldman@chromium.org,dgozman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=427199 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197951

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -378 lines) Patch
M LayoutTests/http/tests/inspector/inspector-test.js View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/inspector/screen-orientation-override.html View 1 chunk +0 lines, -113 lines 0 comments Download
D LayoutTests/inspector/screen-orientation-override-expected.txt View 1 chunk +0 lines, -28 lines 0 comments Download
M Source/devtools/front_end/emulation/OverridesSupport.js View 5 chunks +0 lines, -20 lines 0 comments Download
M Source/devtools/front_end/emulation/ResponsiveDesignView.js View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/devtools/protocol.json View 1 chunk +0 lines, -26 lines 0 comments Download
M Source/modules/modules.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/screen_orientation/ScreenOrientationController.h View 4 chunks +1 line, -10 lines 0 comments Download
M Source/modules/screen_orientation/ScreenOrientationController.cpp View 7 chunks +7 lines, -32 lines 0 comments Download
D Source/modules/screen_orientation/ScreenOrientationInspectorAgent.h View 1 chunk +0 lines, -43 lines 0 comments Download
D Source/modules/screen_orientation/ScreenOrientationInspectorAgent.cpp View 1 chunk +0 lines, -98 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
amineer_google
Created Revert of [DevTools] Implement screen orientation override.
5 years, 5 months ago (2015-06-28 21:58:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220643002/1
5 years, 5 months ago (2015-06-28 21:58:06 UTC) #2
commit-bot: I haz the power
5 years, 5 months ago (2015-06-28 21:58:34 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197951

Powered by Google App Engine
This is Rietveld 408576698