Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Side by Side Diff: webkit/renderer/compositor_bindings/web_content_layer_impl.cc

Issue 122063002: cc: Remove racy initialization code in cc/base/switches.cc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix dynamic linking problem by adding dynamic_annotations dependency to compositor_bindings Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "webkit/renderer/compositor_bindings/web_content_layer_impl.h" 5 #include "webkit/renderer/compositor_bindings/web_content_layer_impl.h"
6 6
7 #include "base/command_line.h"
8 #include "cc/base/switches.h"
9 #include "cc/layers/content_layer.h" 7 #include "cc/layers/content_layer.h"
10 #include "cc/layers/picture_layer.h" 8 #include "cc/layers/picture_layer.h"
11 #include "third_party/WebKit/public/platform/WebContentLayerClient.h" 9 #include "third_party/WebKit/public/platform/WebContentLayerClient.h"
12 #include "third_party/WebKit/public/platform/WebFloatPoint.h" 10 #include "third_party/WebKit/public/platform/WebFloatPoint.h"
13 #include "third_party/WebKit/public/platform/WebFloatRect.h" 11 #include "third_party/WebKit/public/platform/WebFloatRect.h"
14 #include "third_party/WebKit/public/platform/WebRect.h" 12 #include "third_party/WebKit/public/platform/WebRect.h"
15 #include "third_party/WebKit/public/platform/WebSize.h" 13 #include "third_party/WebKit/public/platform/WebSize.h"
16 #include "third_party/skia/include/utils/SkMatrix44.h" 14 #include "third_party/skia/include/utils/SkMatrix44.h"
17 15
18 using cc::ContentLayer; 16 using cc::ContentLayer;
19 using cc::PictureLayer; 17 using cc::PictureLayer;
20 18
21 namespace webkit { 19 namespace webkit {
22 20
23 static bool usingPictureLayer() {
24 return cc::switches::IsImplSidePaintingEnabled();
25 }
26
27 WebContentLayerImpl::WebContentLayerImpl(blink::WebContentLayerClient* client) 21 WebContentLayerImpl::WebContentLayerImpl(blink::WebContentLayerClient* client)
28 : client_(client), 22 : client_(client),
29 ignore_lcd_text_change_(false) { 23 ignore_lcd_text_change_(false) {
30 if (usingPictureLayer()) 24 if (WebLayerImpl::UsingPictureLayer())
31 layer_ = make_scoped_ptr(new WebLayerImpl(PictureLayer::Create(this))); 25 layer_ = make_scoped_ptr(new WebLayerImpl(PictureLayer::Create(this)));
32 else 26 else
33 layer_ = make_scoped_ptr(new WebLayerImpl(ContentLayer::Create(this))); 27 layer_ = make_scoped_ptr(new WebLayerImpl(ContentLayer::Create(this)));
34 layer_->layer()->SetIsDrawable(true); 28 layer_->layer()->SetIsDrawable(true);
35 can_use_lcd_text_ = layer_->layer()->can_use_lcd_text(); 29 can_use_lcd_text_ = layer_->layer()->can_use_lcd_text();
36 } 30 }
37 31
38 WebContentLayerImpl::~WebContentLayerImpl() { 32 WebContentLayerImpl::~WebContentLayerImpl() {
39 if (usingPictureLayer()) 33 if (WebLayerImpl::UsingPictureLayer())
40 static_cast<PictureLayer*>(layer_->layer())->ClearClient(); 34 static_cast<PictureLayer*>(layer_->layer())->ClearClient();
41 else 35 else
42 static_cast<ContentLayer*>(layer_->layer())->ClearClient(); 36 static_cast<ContentLayer*>(layer_->layer())->ClearClient();
43 } 37 }
44 38
45 blink::WebLayer* WebContentLayerImpl::layer() { return layer_.get(); } 39 blink::WebLayer* WebContentLayerImpl::layer() { return layer_.get(); }
46 40
47 void WebContentLayerImpl::setDoubleSided(bool double_sided) { 41 void WebContentLayerImpl::setDoubleSided(bool double_sided) {
48 layer_->layer()->SetDoubleSided(double_sided); 42 layer_->layer()->SetDoubleSided(double_sided);
49 } 43 }
50 44
51 void WebContentLayerImpl::setDrawCheckerboardForMissingTiles(bool enable) { 45 void WebContentLayerImpl::setDrawCheckerboardForMissingTiles(bool enable) {
52 layer_->layer()->SetDrawCheckerboardForMissingTiles(enable); 46 layer_->layer()->SetDrawCheckerboardForMissingTiles(enable);
53 } 47 }
54 48
55 void WebContentLayerImpl::PaintContents(SkCanvas* canvas, 49 void WebContentLayerImpl::PaintContents(SkCanvas* canvas,
56 gfx::Rect clip, 50 gfx::Rect clip,
57 gfx::RectF* opaque) { 51 gfx::RectF* opaque) {
58 if (!client_) 52 if (!client_)
59 return; 53 return;
60 54
61 blink::WebFloatRect web_opaque; 55 blink::WebFloatRect web_opaque;
62 // For picture layers, always record with LCD text. PictureLayerImpl 56 // For picture layers, always record with LCD text. PictureLayerImpl
63 // will turn this off later during rasterization. 57 // will turn this off later during rasterization.
64 bool use_lcd_text = usingPictureLayer() || can_use_lcd_text_; 58 bool use_lcd_text = WebLayerImpl::UsingPictureLayer() || can_use_lcd_text_;
65 client_->paintContents(canvas, clip, use_lcd_text, web_opaque); 59 client_->paintContents(canvas, clip, use_lcd_text, web_opaque);
66 *opaque = web_opaque; 60 *opaque = web_opaque;
67 } 61 }
68 62
69 void WebContentLayerImpl::DidChangeLayerCanUseLCDText() { 63 void WebContentLayerImpl::DidChangeLayerCanUseLCDText() {
70 // It is important to make this comparison because the LCD text status 64 // It is important to make this comparison because the LCD text status
71 // here can get out of sync with that in the layer. 65 // here can get out of sync with that in the layer.
72 if (can_use_lcd_text_ == layer_->layer()->can_use_lcd_text()) 66 if (can_use_lcd_text_ == layer_->layer()->can_use_lcd_text())
73 return; 67 return;
74 68
75 // LCD text cannot be enabled once disabled. 69 // LCD text cannot be enabled once disabled.
76 if (layer_->layer()->can_use_lcd_text() && ignore_lcd_text_change_) 70 if (layer_->layer()->can_use_lcd_text() && ignore_lcd_text_change_)
77 return; 71 return;
78 72
79 can_use_lcd_text_ = layer_->layer()->can_use_lcd_text(); 73 can_use_lcd_text_ = layer_->layer()->can_use_lcd_text();
80 ignore_lcd_text_change_ = true; 74 ignore_lcd_text_change_ = true;
81 layer_->invalidate(); 75 layer_->invalidate();
82 } 76 }
83 77
84 } // namespace webkit 78 } // namespace webkit
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698