Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1596)

Issue 1220603002: Fix the reviver function in JSON.parse

Created:
5 years, 5 months ago by watilde
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix the reviver function in JSON.parse Fixes the reviver function in JSON.parse to update the length to delete elements. If the Revive function argument val is Array we should delete the property if it's undefined. BUG=v8:3136 R=svenpanne@chromium.org LOG=N

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/json.js View 1 chunk +5 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-3136.js View 2 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 23 (8 generated)
watilde
5 years, 5 months ago (2015-06-28 14:50:13 UTC) #1
watilde
5 years, 5 months ago (2015-06-28 15:22:05 UTC) #3
caitp (gmail)
Looks correct per http://www.ecma-international.org/ecma-262/6.0/#sec-internalizejsonproperty
5 years, 5 months ago (2015-06-29 13:50:15 UTC) #4
arv (Not doing code reviews)
LGTM
5 years, 5 months ago (2015-06-29 14:23:43 UTC) #6
arv (Not doing code reviews)
I see that you've signed the CLA. I'll CQ this for you.
5 years, 5 months ago (2015-06-29 14:25:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220603002/1
5 years, 5 months ago (2015-06-29 14:26:10 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/3810)
5 years, 5 months ago (2015-06-29 14:28:54 UTC) #11
arv (Not doing code reviews)
watilde: Can you add yourself to the AUTHORS file too?
5 years, 5 months ago (2015-06-29 14:34:01 UTC) #12
watilde
On 2015/06/29 14:34:01, arv wrote: > watilde: Can you add yourself to the AUTHORS file ...
5 years, 5 months ago (2015-06-29 14:39:09 UTC) #13
arv (Not doing code reviews)
Still LGTM Thank you so much for the fix
5 years, 5 months ago (2015-06-29 14:58:33 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220603002/40001
5 years, 5 months ago (2015-06-29 14:58:41 UTC) #16
commit-bot: I haz the power
Exceeded global retry quota
5 years, 5 months ago (2015-06-29 15:08:50 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220603002/40001
5 years, 5 months ago (2015-06-29 15:10:15 UTC) #20
commit-bot: I haz the power
Exceeded global retry quota
5 years, 5 months ago (2015-06-29 15:16:07 UTC) #22
caitp (gmail)
5 years, 5 months ago (2015-06-29 15:53:30 UTC) #23
On 2015/06/29 15:16:07, commit-bot: I haz the power wrote:
> Exceeded global retry quota

should be green with the webkit tests fixed up, but if they're failing here, it
might mean there are failing blink/chromium tests as well

Powered by Google App Engine
This is Rietveld 408576698