Source/platform/scroll/ScrollbarThemeNonMacCommon.cpp - Issue 1220583004: Refactor DrawingRecorders to check for cached drawings earlier

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/scroll/ScrollbarThemeNonMacCommon.cpp

Issue 1220583004: Refactor DrawingRecorders to check for cached drawings earlier (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix some !'s and &&'s. De Morgan would be proud. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/paint/BlockFlowPainter.cpp ('K') | « Source/platform/scroll/ScrollbarThemeMock.cpp ('k') | Source/platform/scroll/ScrollbarThemeOverlay.cpp » ('j') | Source/web/PageOverlayTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/scroll/ScrollbarThemeNonMacCommon.cpp

diff --git a/Source/platform/scroll/ScrollbarThemeNonMacCommon.cpp b/Source/platform/scroll/ScrollbarThemeNonMacCommon.cpp

index 6e3d3f04a80adf06499477bb272374520f8c71e8..0e53c351a8dbfd144ed68289a7b87ad11117170f 100644

--- a/Source/platform/scroll/ScrollbarThemeNonMacCommon.cpp

+++ b/Source/platform/scroll/ScrollbarThemeNonMacCommon.cpp

@@ -107,10 +107,10 @@ void ScrollbarThemeNonMacCommon::paintTickmarks(GraphicsContext* context, Scroll

if (!tickmarks.size())

return;

- DrawingRecorder recorder(*context, *scrollbar, DisplayItem::ScrollbarTickmarks, rect);

- if (recorder.canUseCachedDrawing())

+ if (DrawingRecorder::useCachedDrawingIfPossible(*context, *scrollbar, DisplayItem::ScrollbarTickmarks))

return;

+ DrawingRecorder recorder(*context, *scrollbar, DisplayItem::ScrollbarTickmarks, rect);

GraphicsContextStateSaver stateSaver(*context);

context->setShouldAntialias(false);