Source/platform/scroll/ScrollbarTheme.cpp - Issue 1220583004: Refactor DrawingRecorders to check for cached drawings earlier

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/scroll/ScrollbarTheme.cpp

Issue 1220583004: Refactor DrawingRecorders to check for cached drawings earlier (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix some !'s and &&'s. De Morgan would be proud. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/paint/BlockFlowPainter.cpp ('K') | « Source/platform/graphics/paint/DrawingRecorder.cpp ('k') | Source/platform/scroll/ScrollbarThemeAura.cpp » ('j') | Source/web/PageOverlayTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/scroll/ScrollbarTheme.cpp

diff --git a/Source/platform/scroll/ScrollbarTheme.cpp b/Source/platform/scroll/ScrollbarTheme.cpp

index 71eb81f8d67906f2812518b444d528f38669c043..a74393eb342882f277b58b0a4399d938fae14aee 100644

--- a/Source/platform/scroll/ScrollbarTheme.cpp

+++ b/Source/platform/scroll/ScrollbarTheme.cpp

@@ -215,10 +215,10 @@ void ScrollbarTheme::paintScrollCorner(GraphicsContext* context, const DisplayIt

if (cornerRect.isEmpty())

return;

- DrawingRecorder recorder(*context, displayItemClient, DisplayItem::ScrollbarCorner, cornerRect);

- if (recorder.canUseCachedDrawing())

+ if (DrawingRecorder::useCachedDrawingIfPossible(*context, displayItemClient, DisplayItem::ScrollbarCorner))

return;

+ DrawingRecorder recorder(*context, displayItemClient, DisplayItem::ScrollbarCorner, cornerRect);

#if OS(MACOSX)

context->fillRect(cornerRect, Color::white);

#else