Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: Source/platform/scroll/ScrollbarThemeOverlay.cpp

Issue 1220583004: Refactor DrawingRecorders to check for cached drawings earlier (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/platform/scroll/ScrollbarThemeNonMacCommon.cpp ('k') | Source/web/PageOverlayTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 return rect; 121 return rect;
122 } 122 }
123 123
124 int ScrollbarThemeOverlay::thumbThickness(ScrollbarThemeClient*) 124 int ScrollbarThemeOverlay::thumbThickness(ScrollbarThemeClient*)
125 { 125 {
126 return m_thumbThickness; 126 return m_thumbThickness;
127 } 127 }
128 128
129 void ScrollbarThemeOverlay::paintThumb(GraphicsContext* context, ScrollbarThemeC lient* scrollbar, const IntRect& rect) 129 void ScrollbarThemeOverlay::paintThumb(GraphicsContext* context, ScrollbarThemeC lient* scrollbar, const IntRect& rect)
130 { 130 {
131 if (DrawingRecorder::useCachedDrawingIfPossible(*context, *scrollbar, Displa yItem::ScrollbarThumb))
132 return;
133
131 DrawingRecorder recorder(*context, *scrollbar, DisplayItem::ScrollbarThumb, rect); 134 DrawingRecorder recorder(*context, *scrollbar, DisplayItem::ScrollbarThumb, rect);
132 if (recorder.canUseCachedDrawing())
133 return;
134 135
135 IntRect thumbRect = rect; 136 IntRect thumbRect = rect;
136 if (scrollbar->orientation() == HorizontalScrollbar) { 137 if (scrollbar->orientation() == HorizontalScrollbar) {
137 thumbRect.setHeight(thumbRect.height() - m_scrollbarMargin); 138 thumbRect.setHeight(thumbRect.height() - m_scrollbarMargin);
138 } else { 139 } else {
139 thumbRect.setWidth(thumbRect.width() - m_scrollbarMargin); 140 thumbRect.setWidth(thumbRect.width() - m_scrollbarMargin);
140 if (scrollbar->isLeftSideVerticalScrollbar()) 141 if (scrollbar->isLeftSideVerticalScrollbar())
141 thumbRect.setX(thumbRect.x() + m_scrollbarMargin); 142 thumbRect.setX(thumbRect.x() + m_scrollbarMargin);
142 } 143 }
143 144
(...skipping 19 matching lines...) Expand all
163 164
164 ScrollbarPart ScrollbarThemeOverlay::hitTest(ScrollbarThemeClient* scrollbar, co nst IntPoint& position) 165 ScrollbarPart ScrollbarThemeOverlay::hitTest(ScrollbarThemeClient* scrollbar, co nst IntPoint& position)
165 { 166 {
166 if (m_allowHitTest == DisallowHitTest) 167 if (m_allowHitTest == DisallowHitTest)
167 return NoPart; 168 return NoPart;
168 169
169 return ScrollbarTheme::hitTest(scrollbar, position); 170 return ScrollbarTheme::hitTest(scrollbar, position);
170 } 171 }
171 172
172 } // namespace blink 173 } // namespace blink
OLDNEW
« no previous file with comments | « Source/platform/scroll/ScrollbarThemeNonMacCommon.cpp ('k') | Source/web/PageOverlayTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698