Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Side by Side Diff: Source/platform/scroll/ScrollbarThemeMock.cpp

Issue 1220583004: Refactor DrawingRecorders to check for cached drawings earlier (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2011 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 return cScrollbarThickness[controlSize]; 45 return cScrollbarThickness[controlSize];
46 } 46 }
47 47
48 bool ScrollbarThemeMock::usesOverlayScrollbars() const 48 bool ScrollbarThemeMock::usesOverlayScrollbars() const
49 { 49 {
50 return RuntimeEnabledFeatures::overlayScrollbarsEnabled(); 50 return RuntimeEnabledFeatures::overlayScrollbarsEnabled();
51 } 51 }
52 52
53 void ScrollbarThemeMock::paintTrackBackground(GraphicsContext* context, Scrollba rThemeClient* scrollbar, const IntRect& trackRect) 53 void ScrollbarThemeMock::paintTrackBackground(GraphicsContext* context, Scrollba rThemeClient* scrollbar, const IntRect& trackRect)
54 { 54 {
55 if (DrawingRecorder::useCachedDrawingIfPossible(*context, *scrollbar, Displa yItem::ScrollbarTrackBackground))
56 return;
57
55 DrawingRecorder recorder(*context, *scrollbar, DisplayItem::ScrollbarTrackBa ckground, trackRect); 58 DrawingRecorder recorder(*context, *scrollbar, DisplayItem::ScrollbarTrackBa ckground, trackRect);
56 if (recorder.canUseCachedDrawing())
57 return;
58 context->fillRect(trackRect, scrollbar->enabled() ? Color::lightGray : Color (0xFFE0E0E0)); 59 context->fillRect(trackRect, scrollbar->enabled() ? Color::lightGray : Color (0xFFE0E0E0));
59 } 60 }
60 61
61 void ScrollbarThemeMock::paintThumb(GraphicsContext* context, ScrollbarThemeClie nt* scrollbar, const IntRect& thumbRect) 62 void ScrollbarThemeMock::paintThumb(GraphicsContext* context, ScrollbarThemeClie nt* scrollbar, const IntRect& thumbRect)
62 { 63 {
63 if (scrollbar->enabled()) { 64 if (!scrollbar->enabled())
64 DrawingRecorder recorder(*context, *scrollbar, DisplayItem::ScrollbarThu mb, thumbRect); 65 return;
65 if (recorder.canUseCachedDrawing()) 66
66 return; 67 if (DrawingRecorder::useCachedDrawingIfPossible(*context, *scrollbar, Displa yItem::ScrollbarThumb))
67 context->fillRect(thumbRect, Color::darkGray); 68 return;
68 } 69
70 DrawingRecorder recorder(*context, *scrollbar, DisplayItem::ScrollbarThumb, thumbRect);
71 context->fillRect(thumbRect, Color::darkGray);
69 } 72 }
70 73
71 } 74 }
72 75
OLDNEW
« no previous file with comments | « Source/platform/scroll/ScrollbarThemeMacOverlayAPI.mm ('k') | Source/platform/scroll/ScrollbarThemeNonMacCommon.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698