Refactor DrawingRecorders to check for cached drawings earlier

Source/core/paint/LayoutObjectDrawingRecorderTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/paint/LayoutObjectDrawingRecorder.h"
 
 #include "core/layout/LayoutTestHelper.h"
 #include "core/layout/LayoutView.h"
 #include "core/paint/DeprecatedPaintLayer.h"
@@ skipping 34 matching lines @@
     }
 
     LayoutView* m_layoutView;
     bool m_originalSlimmingPaintEnabled;
 };
 
 namespace {
 
 void drawNothing(GraphicsContext& context, const LayoutView& layoutView, PaintPhase phase, const FloatRect& bound)
 {
+    if (LayoutObjectDrawingRecorder::useCachedDrawingIfPossible(context, layoutView, phase))
+        return;
+
     LayoutObjectDrawingRecorder drawingRecorder(context, layoutView, phase, bound);
-
-    // Redundant when there's nothing to draw but we must always do this check.
-    if (drawingRecorder.canUseCachedDrawing())
-        return;
 }
 
 void drawRect(GraphicsContext& context, LayoutView& layoutView, PaintPhase phase, const FloatRect& bound)
 {
+    if (LayoutObjectDrawingRecorder::useCachedDrawingIfPossible(context, layoutView, phase))
+        return;
     LayoutObjectDrawingRecorder drawingRecorder(context, layoutView, phase, bound);
-    if (drawingRecorder.canUseCachedDrawing())
-        return;
     IntRect rect(0, 0, 10, 10);
     context.drawRect(rect);
 }
 
 bool isDrawing(const DisplayItem& item)
 {
     return DisplayItem::isDrawingType(item.type());
 }
 
 bool isCached(const DisplayItem& item)
@@ skipping 42 matching lines @@
     EXPECT_TRUE(isCached(*newDisplayItemsBeforeUpdate().elementAt(0)));
     EXPECT_TRUE(isCached(*newDisplayItemsBeforeUpdate().elementAt(1)));
     rootDisplayItemList().commitNewDisplayItems();
     EXPECT_EQ((size_t)2, rootDisplayItemList().displayItems().size());
     EXPECT_TRUE(isDrawing(*rootDisplayItemList().displayItems().elementAt(0)));
     EXPECT_TRUE(isDrawing(*rootDisplayItemList().displayItems().elementAt(1)));
 }
 
 } // namespace
 } // namespace blink