Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 1220513005: Fix dm failures after Cleanup legacy NVPR-related definitions (Closed)

Created:
5 years, 5 months ago by Kimmo Kinnunen
Modified:
5 years, 5 months ago
Reviewers:
jvanverth1, borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix dm failures after Cleanup legacy NVPR-related definitions Non-NV_path_rendering drivers should always return NULL context for NVPR context type request. Fix this. This was needed due to the previous patch trying to implement below: NV_path_rendering drivers should return non-NULL context for NVPR context type request, regardless whether path rendering is actually supported or not. This is due to SAN bots having older drivers and trying to run nvprmsaa config. Committed: https://skia.googlesource.com/skia/+/8b2b3807e6c0dac956666f26f87e1a660e4921b8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/gpu/GrContextFactory.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Kimmo Kinnunen
Broke the bots again.. :(
5 years, 5 months ago (2015-07-01 10:47:52 UTC) #2
Kimmo Kinnunen
5 years, 5 months ago (2015-07-01 11:18:36 UTC) #4
borenet
LGTM
5 years, 5 months ago (2015-07-01 11:24:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220513005/1
5 years, 5 months ago (2015-07-01 11:24:43 UTC) #7
commit-bot: I haz the power
The author kkinnunen@nvidia.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 5 months ago (2015-07-01 11:24:44 UTC) #8
commit-bot: I haz the power
The author kkinnunen@nvidia.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 5 months ago (2015-07-01 11:31:07 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 11:31:32 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8b2b3807e6c0dac956666f26f87e1a660e4921b8

Powered by Google App Engine
This is Rietveld 408576698