Packaged apps manifest requires 'fullscreen' permission for HTML5 api.

Packaged apps manifest requires 'fullscreen' permission for HTML5 api.

For security precautions, packaged applications that
use HTML5 fullscreen api must add 'fullscreen' to the permissions in
the manifest. No user visible message is required.

BUG=166279
TEST=Manually load app chrome/test/data/extensions/api_test/fullscreen/has_permission, launch, click in window, verify it takes window fullscreen. alt-f4 to exit. Load adjacent no_permission test, launch, click, it won't go fullscreen, right click and inspect element, view developer console, verify the 'fullscreen' permission is suggested.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180791

[scheib, 2013-02-04 23:15:09]

Actually -- hold off -- I'm going to prune this back to just apply to Apps.

[scheib, 2013-02-04 23:28:55]

Just for apps now.

[miket_OOO, 2013-02-04 23:55:42]

Very nice. LGTM.

https://codereview.chromium.org/12205002/diff/4001/chrome/test/data/extension...
File
chrome/test/data/extensions/api_test/fullscreen/has_permission/background.js
(right):

https://codereview.chromium.org/12205002/diff/4001/chrome/test/data/extension...
chrome/test/data/extensions/api_test/fullscreen/has_permission/background.js:7:
});
Is this an issue with --similarity being too low?

[scheib, 2013-02-05 16:59:50]

Thanks

https://codereview.chromium.org/12205002/diff/4001/chrome/test/data/extension...
File
chrome/test/data/extensions/api_test/fullscreen/has_permission/background.js
(right):

https://codereview.chromium.org/12205002/diff/4001/chrome/test/data/extension...
chrome/test/data/extensions/api_test/fullscreen/has_permission/background.js:7:
});
On 2013/02/04 23:55:42, miket wrote:
> Is this an issue with --similarity being too low?

It correctly detected that I copied the test apps, some of the files had no
change at all. Seems OK to me to relate them.

[commit-bot: I haz the power, 2013-02-05 17:17:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scheib@chromium.org/12205002/11001

[commit-bot: I haz the power, 2013-02-05 17:18:00]

Presubmit check for 12205002-11001 failed and returned exit status 1.


*----------------------------------*
| integration_test.py has failures |
*----------------------------------*
testAllPublicTemplates (__main__.IntegrationTest)
Traceback (most recent call last):
  File "docs/server2/integration_test.py", line 103, in testAllPublicTemplates
    self._RunPublicTemplatesTest()
  File "docs/server2/integration_test.py", line 96, in _RunPublicTemplatesTest
    self.fail('\n'.join(failures))
AssertionError: Error rendering extensions/permission_warnings.html: 'Type'
object has no attribute 'type_'
Error rendering apps/permission_warnings.html: 'Type' object has no attribute
'type_'

Running presubmit commit checks ...

** Presubmit ERRORS **
IntegrationTest failed!

Presubmit checks took 3.6s to calculate.

[commit-bot: I haz the power, 2013-02-05 18:13:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scheib@chromium.org/12205002/11001

[commit-bot: I haz the power, 2013-02-05 18:13:45]

Presubmit check for 12205002-11001 failed and returned exit status 1.


*----------------------------------*
| integration_test.py has failures |
*----------------------------------*
testAllPublicTemplates (__main__.IntegrationTest)
Traceback (most recent call last):
  File "docs/server2/integration_test.py", line 103, in testAllPublicTemplates
    self._RunPublicTemplatesTest()
  File "docs/server2/integration_test.py", line 96, in _RunPublicTemplatesTest
    self.fail('\n'.join(failures))
AssertionError: Error rendering extensions/permission_warnings.html: 'Type'
object has no attribute 'type_'
Error rendering apps/permission_warnings.html: 'Type' object has no attribute
'type_'

Running presubmit commit checks ...

** Presubmit ERRORS **
IntegrationTest failed!

Presubmit checks took 3.7s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[commit-bot: I haz the power, 2013-02-05 19:28:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scheib@chromium.org/12205002/15003

[commit-bot: I haz the power, 2013-02-05 21:55:22]

Change committed as 180791