Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 1220373003: PPC: [turbofan] Add TruncationMode for TruncateFloat64ToInt32. (Closed)

Created:
5 years, 5 months ago by MTBrandyberry
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [turbofan] Add TruncationMode for TruncateFloat64ToInt32. Port 4b38c15817033ccd9a65efbb3d038ae2423293c2 Original commit message: We actually need round to zero truncation to implement the counterpart of LDoubleToI in TurboFan, which tries to convert a double to an integer as required for keyed load/store optimizations. Drive-by-cleanup: Reduce some code duplication in the InstructionSelector implementations. R=bmeurer@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/2798e118bd8b0819c333f5d4907d979195498f07 Cr-Commit-Position: refs/heads/master@{#29533}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +14 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 5 months ago (2015-07-08 13:24:37 UTC) #1
dstence
lgtm
5 years, 5 months ago (2015-07-08 13:29:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220373003/1
5 years, 5 months ago (2015-07-08 13:30:32 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-08 13:55:00 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 13:55:17 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2798e118bd8b0819c333f5d4907d979195498f07
Cr-Commit-Position: refs/heads/master@{#29533}

Powered by Google App Engine
This is Rietveld 408576698