Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 1220363003: Annotate the CloseEvent interfaces with spec link (Closed)

Created:
5 years, 5 months ago by philipj_slow
Modified:
5 years, 5 months ago
CC:
blink-reviews, yhirano+watch_chromium.org, tyoshino+watch_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Annotate the CloseEvent interfaces with spec link WebSocket already has a spec link. The idea is that each IDL file has one spec link, which should make it easier to write a tool to compare our IDL to the spec's IDL. BUG=460722 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198369

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/modules/websockets/CloseEvent.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/websockets/CloseEventInit.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
philipj_slow
PTAL, and apologies that this CL looks a bit silly on its own, trying to ...
5 years, 5 months ago (2015-07-06 21:37:02 UTC) #2
yhirano
lgtm
5 years, 5 months ago (2015-07-07 01:11:22 UTC) #3
tyoshino (SeeGerritForStatus)
lgtm We're basically referring to the WHATWG HTML spec. So, removal of W3C one is ...
5 years, 5 months ago (2015-07-07 04:07:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220363003/1
5 years, 5 months ago (2015-07-07 07:57:53 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 08:02:15 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198369

Powered by Google App Engine
This is Rietveld 408576698