Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1220333004: [test] Turn off certificate verification when downloading test data on windows. (Closed)

Created:
5 years, 5 months ago by Michael Achenbach
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Turn off certificate verification when downloading test data on windows. BUG=v8:4254 LOG=n NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true TBR=jkummerow@chromium.org Committed: https://crrev.com/3e966abc1ff06d8b707658416343c11b060ff221 Cr-Commit-Position: refs/heads/master@{#29513}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/testrunner/local/utils.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Achenbach
PTAL - last attempt (tested on the bot) - if that's not ok then test262 ...
5 years, 5 months ago (2015-07-07 11:40:21 UTC) #2
Jakob Kummerow
lgtm
5 years, 5 months ago (2015-07-07 11:41:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220333004/1
5 years, 5 months ago (2015-07-07 11:42:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-07 11:42:16 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3e966abc1ff06d8b707658416343c11b060ff221 Cr-Commit-Position: refs/heads/master@{#29513}
5 years, 5 months ago (2015-07-07 11:42:38 UTC) #7
tandrii(chromium)
5 years, 5 months ago (2015-07-10 21:12:01 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698