Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: src/frames.cc

Issue 1220223005: Cleanup frame description constant. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_graph-builder-new-target
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/frames.h ('k') | src/ia32/frames-ia32.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/frames.cc
diff --git a/src/frames.cc b/src/frames.cc
index 5aefe066f5ba7cfb9f871718525fad9858a88a8d..c8edb29a233a90f8a5a5d3f7b424ea58f0dbd632 100644
--- a/src/frames.cc
+++ b/src/frames.cc
@@ -737,6 +737,8 @@ Object* JavaScriptFrame::GetOriginalConstructor() const {
fp = Memory::Address_at(fp + StandardFrameConstants::kCallerFPOffset);
}
DCHECK(IsConstructFrame(fp));
+ DCHECK_EQ(StandardFrameConstants::kExpressionsOffset - 2 * kPointerSize,
arv (Not doing code reviews) 2015/07/06 18:14:19 Can this be a compile time assert instead?
Michael Starzinger 2015/07/06 18:20:54 Done.
+ ConstructFrameConstants::kOriginalConstructorOffset);
return GetExpression(fp, 2);
}
@@ -744,6 +746,8 @@ Object* JavaScriptFrame::GetOriginalConstructor() const {
int JavaScriptFrame::GetArgumentsLength() const {
// If there is an arguments adaptor frame get the arguments length from it.
if (has_adapted_arguments()) {
+ DCHECK_EQ(StandardFrameConstants::kExpressionsOffset - 0 * kPointerSize,
arv (Not doing code reviews) 2015/07/06 18:14:19 same
Michael Starzinger 2015/07/06 18:20:54 Done.
+ ArgumentsAdaptorFrameConstants::kLengthOffset);
return Smi::cast(GetExpression(caller_fp(), 0))->value();
} else {
return GetNumberOfIncomingArguments();
« no previous file with comments | « src/frames.h ('k') | src/ia32/frames-ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698