Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1220193004: Fix cluster-fuzz found regression with d8 Workers (Closed)

Created:
5 years, 5 months ago by binji
Modified:
5 years, 5 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix cluster-fuzz found regression with d8 Workers This one occurred when serializing an object. When the property getter threw an exception, that value was skipped, but the property count wasn't updated. The deserializer then tried to deserialize the wrong value. BUG=chromium:506549 R=jarin@chromium.org LOG=n Committed: https://crrev.com/54920cd2f08549130e363b5bc801424a8eecc7d2 Cr-Commit-Position: refs/heads/master@{#29541}

Patch Set 1 #

Patch Set 2 : add assertThrows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M src/d8.cc View 2 chunks +6 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-506549.js View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
binji
5 years, 5 months ago (2015-07-06 06:15:09 UTC) #1
Jarin
lgtm
5 years, 5 months ago (2015-07-08 16:28:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220193004/20001
5 years, 5 months ago (2015-07-08 17:29:56 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-08 17:57:55 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 17:58:11 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/54920cd2f08549130e363b5bc801424a8eecc7d2
Cr-Commit-Position: refs/heads/master@{#29541}

Powered by Google App Engine
This is Rietveld 408576698