chrome/browser/memory_details_win.cc - Issue 1220133003: Fixed all unused-variable Clang warnings on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/memory_details_win.cc

Issue 1220133003: Fixed all unused-variable Clang warnings on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iaccessible2-fix-gn

Patch Set: Fix GYP build with -Wunused-variable. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/install_verification/win/imported_module_verification.cc ('k') | chrome/browser/ui/browser_focus_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/memory_details_win.cc

diff --git a/chrome/browser/memory_details_win.cc b/chrome/browser/memory_details_win.cc

index 8cb2056b652d12a2599e4383cd7ddcd87c4094d6..bcb98db1f759b3bb09f0683eadaa317bc6bf752d 100644

--- a/chrome/browser/memory_details_win.cc

+++ b/chrome/browser/memory_details_win.cc

@@ -25,7 +25,7 @@

using content::BrowserThread;

// Known browsers which we collect details for.

-enum {

+enum BrowserProcess {

Matt Giuca 2015/07/03 03:46:29 This was my favourite one :) That's not how you e

CHROME_BROWSER = 0,

CHROME_NACL_PROCESS,

IE_BROWSER,

@@ -35,7 +35,7 @@ enum {

IE_64BIT_BROWSER,

KONQUEROR_BROWSER,

MAX_BROWSERS

-} BrowserProcess;

+};

MemoryDetails::MemoryDetails() {

base::FilePath browser_process_path;