components/printing/test/print_web_view_helper_browsertest.cc - Issue 1220133003: Fixed all unused-variable Clang warnings on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/printing/test/print_web_view_helper_browsertest.cc

Issue 1220133003: Fixed all unused-variable Clang warnings on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iaccessible2-fix-gn

Patch Set: Rebase. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/printing/test/print_web_view_helper_browsertest.cc

diff --git a/components/printing/test/print_web_view_helper_browsertest.cc b/components/printing/test/print_web_view_helper_browsertest.cc

index 82d94935434feb1b2f8c92e70179df36ce836b76..28d25231ff507568f9cf9a11ec2bc8bf258abbd5 100644

--- a/components/printing/test/print_web_view_helper_browsertest.cc

+++ b/components/printing/test/print_web_view_helper_browsertest.cc

@@ -404,7 +404,7 @@ struct TestPageData {

const wchar_t* file;

};

-#if defined(OS_WIN) || defined(OS_MACOSX)

+#if defined(OS_MACOSX) && defined(ENABLE_BASIC_PRINTING)

const TestPageData kTestPages[] = {

{

"<html>"

@@ -417,23 +417,17 @@ const TestPageData kTestPages[] = {

"<body style=\"background-color: white;\">"

"<p style=\"font-family: arial;\">Hello World!</p>"

"</body>",

-#if defined(OS_MACOSX)

- // Mac printing code compensates for the WebKit scale factor while

- // generating

- // the metafile, so we expect smaller pages.

+ // Mac printing code compensates for the WebKit scale factor while

+ // generating the metafile, so we expect smaller pages. (On non-Mac

+ // platforms, this would be 675x900).

600,

780,

-#else

- 1,

- 675,

- 900,

-#endif

NULL,

};

-#endif // defined(OS_WIN) || defined(OS_MACOSX)

+#endif // defined(OS_MACOSX) && defined(ENABLE_BASIC_PRINTING)

} // namespace

// TODO(estade): need to port MockPrinter to get this on Linux. This involves

« chrome/browser/memory_details_win.cc ('K') | « components/crash/app/breakpad_win.cc ('k') | content/browser/download/base_file_win.cc » ('j') | remoting/host/remoting_me2me_host.cc » ('J')