Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Side by Side Diff: chrome/browser/ui/browser_focus_uitest.cc

Issue 1220133003: Fixed all unused-variable Clang warnings on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iaccessible2-fix-gn
Patch Set: Rebase. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/files/file_util.h" 6 #include "base/files/file_util.h"
7 #include "base/format_macros.h" 7 #include "base/format_macros.h"
8 #include "base/message_loop/message_loop.h" 8 #include "base/message_loop/message_loop.h"
9 #include "base/path_service.h" 9 #include "base/path_service.h"
10 #include "base/strings/stringprintf.h" 10 #include "base/strings/stringprintf.h"
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 // TODO(jcampan): http://crbug.com/23683 for linux. 48 // TODO(jcampan): http://crbug.com/23683 for linux.
49 // TODO(suzhe): http://crbug.com/49737 for mac. 49 // TODO(suzhe): http://crbug.com/49737 for mac.
50 #define MAYBE_TabsRememberFocusFindInPage DISABLED_TabsRememberFocusFindInPage 50 #define MAYBE_TabsRememberFocusFindInPage DISABLED_TabsRememberFocusFindInPage
51 #elif defined(OS_WIN) 51 #elif defined(OS_WIN)
52 // Flaky, http://crbug.com/62537. 52 // Flaky, http://crbug.com/62537.
53 #define MAYBE_TabsRememberFocusFindInPage DISABLED_TabsRememberFocusFindInPage 53 #define MAYBE_TabsRememberFocusFindInPage DISABLED_TabsRememberFocusFindInPage
54 #endif 54 #endif
55 55
56 namespace { 56 namespace {
57 57
58 #if defined(OS_POSIX)
58 // The delay waited in some cases where we don't have a notifications for an 59 // The delay waited in some cases where we don't have a notifications for an
59 // action we take. 60 // action we take.
60 const int kActionDelayMs = 500; 61 const int kActionDelayMs = 500;
62 #endif
61 63
62 const char kSimplePage[] = "/focus/page_with_focus.html"; 64 const char kSimplePage[] = "/focus/page_with_focus.html";
63 const char kStealFocusPage[] = "/focus/page_steals_focus.html"; 65 const char kStealFocusPage[] = "/focus/page_steals_focus.html";
64 const char kTypicalPage[] = "/focus/typical_page.html"; 66 const char kTypicalPage[] = "/focus/typical_page.html";
65 67
66 class BrowserFocusTest : public InProcessBrowserTest { 68 class BrowserFocusTest : public InProcessBrowserTest {
67 public: 69 public:
68 // InProcessBrowserTest overrides: 70 // InProcessBrowserTest overrides:
69 void SetUpOnMainThread() override { 71 void SetUpOnMainThread() override {
70 ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady()); 72 ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
(...skipping 628 matching lines...) Expand 10 before | Expand all | Expand 10 after
699 content::NOTIFICATION_NAV_ENTRY_COMMITTED, 701 content::NOTIFICATION_NAV_ENTRY_COMMITTED,
700 content::NotificationService::AllSources()); 702 content::NotificationService::AllSources());
701 chrome::GoForward(browser(), CURRENT_TAB); 703 chrome::GoForward(browser(), CURRENT_TAB);
702 forward_nav_observer.Wait(); 704 forward_nav_observer.Wait();
703 } 705 }
704 706
705 EXPECT_FALSE(IsViewFocused(VIEW_ID_OMNIBOX)); 707 EXPECT_FALSE(IsViewFocused(VIEW_ID_OMNIBOX));
706 } 708 }
707 709
708 } // namespace 710 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698