Fixed all unused-variable Clang warnings on Windows.

sandbox/win/src/process_mitigations_test.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/strings/stringprintf.h"
 #include "base/win/scoped_handle.h"
 
 #include "base/win/windows_version.h"
 #include "sandbox/win/src/nt_internals.h"
 #include "sandbox/win/src/process_mitigations.h"
@@ skipping 147 matching lines @@
       return SBOX_TEST_NOT_FOUND;
 
     ULONG size = 0;
     ULONG dep_flags = 0;
     if (!SUCCEEDED(query_information_process(::GetCurrentProcess(),
                                              ProcessExecuteFlags, &dep_flags,
                                              sizeof(dep_flags), &size))) {
       return SBOX_TEST_THIRD_ERROR;
     }
 
-    static const int MEM_EXECUTE_OPTION_ENABLE = 1;
+    // static const int MEM_EXECUTE_OPTION_ENABLE = 1;

[Nico, 2015/07/02 17:34:26]

?

[Matt Giuca, 2015/07/03 03:46:29]

Well I thought that since this seems to represent a set of bit flags, we should
not remove the information about what each bit means from the code (in case
someone wants to use these bits in the future).

Should I just delete these?

[Nico, 2015/07/03 04:11:15]

As-is, it looks like code that was left in accidentally. If you want to keep
them, I'd make the comments look less like code. (I'd just delete them here, but
maybe a sandbox/OWNER sees it differently)

[Matt Giuca, 2015/07/03 04:33:45]

jschuh: Can I get your quick opinion on this. You added these constants in
https://codereview.chromium.org/10690058 (and even then, two of them were
unused).

Can I just delete these two altogether, or should I leave them in a comment of
some form?

     static const int MEM_EXECUTE_OPTION_DISABLE = 2;
-    static const int MEM_EXECUTE_OPTION_ATL7_THUNK_EMULATION = 4;
+    // static const int MEM_EXECUTE_OPTION_ATL7_THUNK_EMULATION = 4;

[Nico, 2015/07/02 17:34:26]

?

[jschuh, 2015/07/06 22:16:18]

Yeah, looks like dead constants. lgtm on removing them

[Matt Giuca, 2015/07/07 04:52:17]

Well they were dead the moment they were added, so I was wondering if they were
there for future purposes, but sure, I'll just remove them.

     static const int MEM_EXECUTE_OPTION_PERMANENT = 8;
     dep_flags &= 0xff;
 
     if (dep_flags != (MEM_EXECUTE_OPTION_DISABLE |
                       MEM_EXECUTE_OPTION_PERMANENT)) {
       return SBOX_TEST_FOURTH_ERROR;
     }
   }
 
   return SBOX_TEST_SUCCEEDED;
@@ skipping 58 matching lines @@
   EXPECT_EQ(policy->SetProcessMitigations(MITIGATION_WIN32K_DISABLE),
             SBOX_ALL_OK);
   EXPECT_EQ(policy->AddRule(sandbox::TargetPolicy::SUBSYS_WIN32K_LOCKDOWN,
                             sandbox::TargetPolicy::FAKE_USER_GDI_INIT, NULL),
             sandbox::SBOX_ALL_OK);
   EXPECT_EQ(SBOX_TEST_SUCCEEDED, runner.RunTest(L"CheckWin8Lockdown"));
 }
 
 }  // namespace sandbox