Issue 1220113003: Remove &glyph from SkASSERT.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1220113003: Remove &glyph from SkASSERT. (Closed)

Created:
5 years, 5 months ago by dcheng

Modified:
5 years, 5 months ago

Reviewers:
mtklein, reed1

CC:
reviews_skia.org, bungeman-skia, Nico

Base URL:
https://chromium.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Remove &glyph from SkASSERT. This tickles a warning in Clang: reference cannot be bound to dereferenced null pointer in well-defined C++ code; pointer may be assumed to always convert to true [-Wundefined-bool-conversion] BUG=none Committed: https://skia.googlesource.com/skia/+/2f19b551ac10b96a1a35a147063cd4300d6fe07a

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/ports/SkScalerContext_win_dw.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220113003/1

5 years, 5 months ago (2015-07-08 02:28:11 UTC) #6

commit-bot: I haz the power

5 years, 5 months ago (2015-07-08 02:35:57 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2f19b551ac10b96a1a35a147063cd4300d6fe07a

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages