Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(990)

Side by Side Diff: chrome/browser/resources/options/password_manager_list.js

Issue 122003002: Show username on password manager list tooltip (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert password display on pwd manager tooltip Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options.passwordManager', function() { 5 cr.define('options.passwordManager', function() {
6 /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel; 6 /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel;
7 /** @const */ var DeletableItemList = options.DeletableItemList; 7 /** @const */ var DeletableItemList = options.DeletableItemList;
8 /** @const */ var DeletableItem = options.DeletableItem; 8 /** @const */ var DeletableItem = options.DeletableItem;
9 /** @const */ var List = cr.ui.List; 9 /** @const */ var List = cr.ui.List;
10 10
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 // default favicon for the domain and that the URL has a scheme if none 49 // default favicon for the domain and that the URL has a scheme if none
50 // is present in the password manager. 50 // is present in the password manager.
51 urlLabel.style.backgroundImage = getFaviconImageSet( 51 urlLabel.style.backgroundImage = getFaviconImageSet(
52 'origin/' + this.url, 16); 52 'origin/' + this.url, 16);
53 this.contentElement.appendChild(urlLabel); 53 this.contentElement.appendChild(urlLabel);
54 54
55 // The stored username. 55 // The stored username.
56 var usernameLabel = this.ownerDocument.createElement('div'); 56 var usernameLabel = this.ownerDocument.createElement('div');
57 usernameLabel.className = 'name'; 57 usernameLabel.className = 'name';
58 usernameLabel.textContent = this.username; 58 usernameLabel.textContent = this.username;
59 usernameLabel.setAttribute('title', this.username);
James Hawkins 2013/12/29 21:09:17 usernameLabel.title = this.username should suffice
carloschilazo 2013/12/29 21:23:23 Done.
59 this.contentElement.appendChild(usernameLabel); 60 this.contentElement.appendChild(usernameLabel);
60 61
61 // The stored password. 62 // The stored password.
62 var passwordInputDiv = this.ownerDocument.createElement('div'); 63 var passwordInputDiv = this.ownerDocument.createElement('div');
63 passwordInputDiv.className = 'password'; 64 passwordInputDiv.className = 'password';
64 65
65 // The password input field. 66 // The password input field.
66 var passwordInput = this.ownerDocument.createElement('input'); 67 var passwordInput = this.ownerDocument.createElement('input');
67 passwordInput.type = 'password'; 68 passwordInput.type = 'password';
68 passwordInput.className = 'inactive-password'; 69 passwordInput.className = 'inactive-password';
(...skipping 264 matching lines...) Expand 10 before | Expand all | Expand 10 after
333 }, 334 },
334 }; 335 };
335 336
336 return { 337 return {
337 PasswordListItem: PasswordListItem, 338 PasswordListItem: PasswordListItem,
338 PasswordExceptionsListItem: PasswordExceptionsListItem, 339 PasswordExceptionsListItem: PasswordExceptionsListItem,
339 PasswordsList: PasswordsList, 340 PasswordsList: PasswordsList,
340 PasswordExceptionsList: PasswordExceptionsList, 341 PasswordExceptionsList: PasswordExceptionsList,
341 }; 342 };
342 }); 343 });
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698