Show username on password manager list tooltip

Show username on password manager list tooltip

BUG=chromium:330145
TEST=On password manager list, username should be displayed on its section tooltip

R=dbeam@chromium.org, estade@chromium.org, jhawkins@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243244

[James Hawkins, 2013-12-29 16:40:49]

Thanks for the patch, Carlos.  I'm OK with the username tooltip for now, but I
have some reservations about the password, and more generally about finding a
better solution to the sizing of the columns:
* Are there any security concerns with putting the password in a tooltip?  It's
likely the answer is no, but I want to run it by a security person before we
move forward with that piece.
* Should we opt for a more dynamic solution involving the size of the columns?

I'll try to wrangle up a PM and security person to get some questions, but in
the meantime, I'm OK with the username part of this CL if you want to undo the
password piece for now.

[carloschilazo, 2013-12-29 21:03:48]

Thank you for the feedback James, those are excellent points. I've reverted the
password part of it and updated the necessary.

Thanks!

[James Hawkins, 2013-12-29 21:09:16]

https://codereview.chromium.org/122003002/diff/50001/chrome/browser/resources...
File chrome/browser/resources/options/password_manager_list.js (right):

https://codereview.chromium.org/122003002/diff/50001/chrome/browser/resources...
chrome/browser/resources/options/password_manager_list.js:59:
usernameLabel.setAttribute('title', this.username);
usernameLabel.title = this.username should suffice.

[carloschilazo, 2013-12-29 21:23:23]

Fixed

https://codereview.chromium.org/122003002/diff/50001/chrome/browser/resources...
File chrome/browser/resources/options/password_manager_list.js (right):

https://codereview.chromium.org/122003002/diff/50001/chrome/browser/resources...
chrome/browser/resources/options/password_manager_list.js:59:
usernameLabel.setAttribute('title', this.username);
On 2013/12/29 21:09:17, James Hawkins wrote:
> usernameLabel.title = this.username should suffice.

Done.

[James Hawkins, 2013-12-29 21:46:10]

lgtm

[commit-bot: I haz the power, 2014-01-02 22:39:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/carloschilazo@gmail.com/122003002/110001

[commit-bot: I haz the power, 2014-01-02 23:28:29]

Retried try job too often on linux_rel for step(s) chromedriver2_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[carloschilazo, 2014-01-06 21:39:32]

On 2014/01/02 23:28:29, I haz the power (commit-bot) wrote:
> Retried try job too often on linux_rel for step(s) chromedriver2_unittests
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Hey, just chiming in, Is there anything pending to do from my end? thanks!

[Evan Stade, 2014-01-06 22:22:11]

On 2014/01/06 21:39:32, carloschilazo wrote:
> On 2014/01/02 23:28:29, I haz the power (commit-bot) wrote:
> > Retried try job too often on linux_rel for step(s) chromedriver2_unittests
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...
> 
> Hey, just chiming in, Is there anything pending to do from my end? thanks!

it's probably flake. I'll try again.

[commit-bot: I haz the power, 2014-01-06 22:25:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/carloschilazo@gmail.com/122003002/110001

[commit-bot: I haz the power, 2014-01-07 10:45:41]

Change committed as 243244