Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1219993002: Remove unused is_class_scope bit from Scope and ScopeInfo (Closed)

Created:
5 years, 5 months ago by adamk
Modified:
5 years, 5 months ago
Reviewers:
rossberg
CC:
v8-dev, arv (Not doing code reviews), conradw
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove unused is_class_scope bit from Scope and ScopeInfo This was added in https://chromium.googlesource.com/v8/v8/+/4a709dd65, but the only check for it that remained in the final patch is inside a DCHECK. It appears that the approach for checking use of class names in methods evolved quite a bit over the review of the original patch. Committed: https://crrev.com/e334410340e6ec1a7439b82705e1b65591d3062d Cr-Commit-Position: refs/heads/master@{#29428}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -27 lines) Patch
M src/objects.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/parser.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/scopeinfo.cc View 3 chunks +0 lines, -7 lines 0 comments Download
M src/scopes.h View 2 chunks +0 lines, -9 lines 0 comments Download
M src/scopes.cc View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
adamk
5 years, 5 months ago (2015-06-30 23:12:45 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219993002/1
5 years, 5 months ago (2015-06-30 23:13:06 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-06-30 23:41:43 UTC) #6
rossberg
I'd have to check, this might have been a preparatory addition for yet missing class ...
5 years, 5 months ago (2015-07-01 17:16:49 UTC) #7
adamk
On 2015/07/01 17:16:49, rossberg wrote: > I'd have to check, this might have been a ...
5 years, 5 months ago (2015-07-01 17:18:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219993002/1
5 years, 5 months ago (2015-07-01 17:19:07 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-01 17:20:53 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 17:21:16 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e334410340e6ec1a7439b82705e1b65591d3062d
Cr-Commit-Position: refs/heads/master@{#29428}

Powered by Google App Engine
This is Rietveld 408576698