Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1219983006: Move the identical getInfo parameters from the windows API into a shared type.

Created:
5 years, 5 months ago by not at google - send to devlin
Modified:
5 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move the identical getInfo parameters from the windows API into a shared type. This will make adding new options to the windows API getters trivial. BUG=394341 R=rockot@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -36 lines) Patch
M chrome/common/extensions/api/windows.json View 5 chunks +16 lines, -36 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
not at google - send to devlin
5 years, 5 months ago (2015-07-07 21:33:36 UTC) #2
not at google - send to devlin
and by the magic of the schema compiler, *somehow* this doesn't need changing any C++ ...
5 years, 5 months ago (2015-07-07 21:34:10 UTC) #3
Ken Rockot(use gerrit already)
On 2015/07/07 21:34:10, kalman wrote: > and by the magic of the schema compiler, *somehow* ...
5 years, 5 months ago (2015-07-07 21:36:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219983006/1
5 years, 5 months ago (2015-07-07 21:51:42 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 00:08:35 UTC) #8 
Exceeded global retry quota

Powered by Google App Engine
This is Rietveld 408576698