Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: src/code-stubs.cc

Issue 1219943002: Expose SIMD.Float32x4 type to Javascript. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Back out changes to include/v8.h Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-stubs.h ('k') | src/code-stubs-hydrogen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.cc
diff --git a/src/code-stubs.cc b/src/code-stubs.cc
index 08fa35a6c273fd24214f9109ce56e0c8bd4671dd..3b41f9e60934eef6adef9df64667bcc41ea9c939 100644
--- a/src/code-stubs.cc
+++ b/src/code-stubs.cc
@@ -968,6 +968,7 @@ std::ostream& operator<<(std::ostream& os, const ToBooleanStub::Types& s) {
if (s.Contains(ToBooleanStub::STRING)) p.Add("String");
if (s.Contains(ToBooleanStub::SYMBOL)) p.Add("Symbol");
if (s.Contains(ToBooleanStub::HEAP_NUMBER)) p.Add("HeapNumber");
+ if (s.Contains(ToBooleanStub::SIMD_VALUE)) p.Add("SimdValue");
return os << ")";
}
@@ -1000,6 +1001,9 @@ bool ToBooleanStub::Types::UpdateStatus(Handle<Object> object) {
Add(HEAP_NUMBER);
double value = HeapNumber::cast(*object)->value();
return value != 0 && !std::isnan(value);
+ } else if (object->IsFloat32x4()) {
+ Add(SIMD_VALUE);
+ return true;
} else {
// We should never see an internal object at runtime here!
UNREACHABLE();
@@ -1009,10 +1013,10 @@ bool ToBooleanStub::Types::UpdateStatus(Handle<Object> object) {
bool ToBooleanStub::Types::NeedsMap() const {
- return Contains(ToBooleanStub::SPEC_OBJECT)
- || Contains(ToBooleanStub::STRING)
- || Contains(ToBooleanStub::SYMBOL)
- || Contains(ToBooleanStub::HEAP_NUMBER);
+ return Contains(ToBooleanStub::SPEC_OBJECT) ||
+ Contains(ToBooleanStub::STRING) || Contains(ToBooleanStub::SYMBOL) ||
+ Contains(ToBooleanStub::HEAP_NUMBER) ||
+ Contains(ToBooleanStub::SIMD_VALUE);
}
« no previous file with comments | « src/code-stubs.h ('k') | src/code-stubs-hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698