src/x87/code-stubs-x87.cc - Issue 1219943002: Expose SIMD.Float32x4 type to Javascript.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x87/code-stubs-x87.cc

Issue 1219943002: Expose SIMD.Float32x4 type to Javascript. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Don't install SIMD object without the simd flag. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x87/code-stubs-x87.cc

diff --git a/src/x87/code-stubs-x87.cc b/src/x87/code-stubs-x87.cc

index 875b798bdafd19c431af1ea4992069bc6e18bbaa..68c111e1637de1f76cfa0ee151901f2d2dbc4b0a 100644

--- a/src/x87/code-stubs-x87.cc

+++ b/src/x87/code-stubs-x87.cc

@@ -1379,6 +1379,9 @@ void CompareICStub::GenerateGeneric(MacroAssembler* masm) {

// Call runtime on identical symbols since we need to throw a TypeError.

__ cmpb(ecx, static_cast<uint8_t>(SYMBOL_TYPE));

__ j(equal, &runtime_call, Label::kFar);

+ // Call runtime on identical SIMD values since we must throw a TypeError.

+ __ cmpb(ecx, static_cast<uint8_t>(FLOAT32X4_TYPE));

+ __ j(equal, &runtime_call, Label::kFar);

if (is_strong(strength())) {

// We have already tested for smis and heap numbers, so if both

// arguments are not strings we must proceed to the slow case.